Re: [PATCH CVS] broken proto

[Karim BELABAS <Karim.Belabas@math.u-psud.fr>]

On Mon, 7 Apr 2003, Bill Allombert wrote:
> On Sun, Apr 06, 2003 at 10:35:05PM -0700, Ilya Zakharevich wrote:
> > The prototype strings were broken again.
>
> Looking at your patch it is the valence code that are broken, not the
> string, or was I mistaken ?

Got the same impression. Well, since there's a mismatch between prototype
string and "valence" code, one can consider either of them is broken...

> I think we should remove completly valence code from GP. They are not
> used anymore, not documented and wrong.

They are still used (in a silly way) to handle functions without mandatory
arguments [ valence 0 ].

I can recode the check using only the prototype. It wil be slightly slower,
but it shoudn't matter.

[ Hum, in fact it looks like this can be handled generically through the
match_comma() macro, simplifying the code, while incurring no real speed
penalty! ]

> It seems easier to generate them with a perl script for programs that need
> them. Using the description system, it will be much easier to do.

Agreed.

    Karim.
-- 
Karim Belabas                     Tel: (+33) (0)1 69 15 57 48
Dép. de Mathématiques, Bât. 425   Fax: (+33) (0)1 69 15 60 19
Université Paris-Sud              http://www.math.u-psud.fr/~belabas/
F-91405 Orsay (France)            http://www.parigp-home.de/  [PARI/GP]