Re: Issue with fullfactor

[Jean-Luc Arnaud <jean-luc@filmsons.com>]

Le 08/06/2023 à 15:20, Bill Allombert a écrit :
> On Thu, Jun 08, 2023 at 03:08:18PM +0200, Jean-Luc ARNAUD wrote:
> > Hello,
> >
> > I installed fullfactor as described in the doc, AFAIK.
> >
> > Now, launching it with "\r fullfactor.gp", I'm getting this warning:
> >
> > ? \r fullfactor.gp
> >    ***   variable name expected:
> > isprimepower(x)=my(p);if(!ispower(x,,&p),p=x);
> >    *** ^----------------------------------------------
> >    ***   variable name expected:
> > logint(x,b=2)=my(r=0);while(x>=b,x=x\b;r++);r;
> >    *** ^----------------------------------------------
> > cpu time = 13 ms, real time = 19 ms.
> >    ***   unexpected ';': ...1,if(reg>numpbases,if(c++;c>numcbases,break);b
> >    *** ^---------------------
> >    ***   too few arguments: ...ctor(logint(eulerphi(2*b)));my(g=vectorsmall(e
> > *** ^---------------------
> Yes, this functions already exist in GP, so you can remove the definition.
> the only issue is that you have to replace logint(x) byt logint(x,2).
>
> I will send you a fixed version.
>
> Cheers,
> Bill.
Many thanks, Bill and Max, for explanation and help.
Bill, your new version of fullfactor works like a charm!

Jean-Luc