|
Karim Belabas on Sat, 26 Aug 2023 15:51:51 +0200
|
[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]
|
Re: bug in simplify_shallow
|
- To: Charles Greathouse <crgreathouse@gmail.com>
- Subject: Re: bug in simplify_shallow
- From: Karim Belabas <Karim.Belabas@u-bordeaux.fr>
- Date: Sat, 26 Aug 2023 15:47:09 +0200
- Arc-authentication-results: i=1; smail; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; d=math.u-bordeaux.fr; s=openarc; t=1693057620; c=relaxed/relaxed; bh=0Yu0CyAyuya/1ci/UfQxNwsYogSqBfcSNk6T9tM3NmY=; h=Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:References: MIME-Version:Content-Type:Content-Disposition: Content-Transfer-Encoding:In-Reply-To; b=1J2HdzymsfUzufdF0eEeTmTE9UWw8KfStPPQoXdjuTA3P3EMWdwqHmAQwDeKOn12k4Qt86J74F4NXEsRmaxfwBUp9X6I9Yri9AOUH1RhqlUfSrD5TYcoGdVWJXi16HyhNfaNl5FvG/c1bvZKFiHwV6NXLZGbzcQXAQIang8kpR00dpxW+wTXAuKB3ISmoOQWdDE1LuVCRbNkFLgZOF0dSjdy2L8d9oOpnz48gAZWLlQpjDhp6De14g3iNpurbsVy1UV3K8wsdSp9Jpe41iNIVEOjpQ68bH1szLEEIcK+jYGa7NM9ehY5xeJzlJBgYLSZPhJBOyjC7CkSWYV86LvTaCQvzbriXjr3fXS6p0zKXZaCCxCAcH1Ce7kjJIIQmvsLEXMcmYhT3RWTo7pHU6G6b0NayWLlUSrA8LVAofzwF3siyXdFC1PYBOnrL1fyk7GEwA7VixhcxVclKmYIV8yYBk63e9GeU1Ko6YMLhnoWJTcYfg9FZwzLdclIaFSd4bV4n/7Qa+qP8lOLvrDi+T8YAZHpsyoHy7Sjx68XIhB7zHRENI1Eo3BzZB01mh/ftIOT/CpP20LMDvQXFIAWumDdn0sERnJrfyyialUP399TL/vs1kGVtXn1Ric/LkKIuHfbSQjHIAeVnI19mwkHyNaqfSA4Ki2yI4zW+aZAegF66fs=
- Arc-seal: i=1; a=rsa-sha256; d=math.u-bordeaux.fr; s=openarc; t=1693057620; cv=none; b=GWpm8P7k3AyEFOHmb/4Gs640awZxNE0a94DzQhBVhrEXTIHZGEJyTPJlXGncXxnWsYt9VIBTvhMhtggI53IZv5pskToj+qmlMBopqWSsundX1bUTX3U6oGPHg0V9/hYAM0wyBVroEHaEzfyzA0hY/eN9c7NdupbCuX1tkVftZUjUa3zBFOxYVp0WAPn0/BBhzRKm4FikJ2DaZlcgDwJ0UgX7ngFu99uQV7tf7FDiqaYBNFlNzLnuN4yg+s54JHney0O4kZwpYDRt5fNPe8ikj/uH13yPmQwbmapVtYrQMCyhml0hn5MubcYIgUoYW5kMzkhZQm95izIDciwyunvQY9MlluVe9Za3ddiPWBfIzUsrZZfTQFjm453hidCWGp8IR3hDgv/fvxX2mkayyzrsunHE4VQ3HEPAHNBqE6x8vRI09cdg0TKGdgXclzCmtbH+bcULgnwryJu87B/dTVSbCLsm9KhfOzmF3Ph6DQxD3FpFWD5gn4ChAFkuPB6WpCo0eNzF+Od/LNdHO/343qzUKhngzmH8ghDWh+2N2JfnNEXLF1F0qBwQGEt3+XqyrF7gDp1Dd7Ia+BrICl+s0I/DB770q+UpMpqTpwJApFr+MDzx1hxo2XhZXJGbhuWwCuTu+HdEkVq9Qzj3OhLw2NvWJYKgbmhCc2mPvGZGe6LVFmU=
- Authentication-results: smail; arc=none
- Cc: "Ruud H.G. van Tol" <rvtol@isolution.nl>, pari-dev@pari.math.u-bordeaux.fr
- Delivery-date: Sat, 26 Aug 2023 15:51:52 +0200
- In-reply-to: <CANXmBjzx4t330CnCzz4TzMfPFVVYg+-T7iskqECzh_+_2G2ABw@mail.gmail.com>
- Mail-followup-to: Charles Greathouse <crgreathouse@gmail.com>, "Ruud H.G. van Tol" <rvtol@isolution.nl>, pari-dev@pari.math.u-bordeaux.fr
- References: <1e144fa5-864d-450e-a109-1fac8300bf88@isolution.nl> <CANXmBjzx4t330CnCzz4TzMfPFVVYg+-T7iskqECzh_+_2G2ABw@mail.gmail.com>
You'll see it with valgrind.
>From the GP code, I can guess what's happening: the lexical variable L
will be destroyed (gunclone) when we leave the user function scope. But
that user function still returns the return value of listput() which is
the element stored in the list. The latter is a 'clone' (as all list
entries), so supposedly safe. The lexical variable destructor breaks
that asumption.
I don't think the reference count machinery currently in place can
deal with this. Adding a gcopy somewhere should be enough (but slow down
all 'listput' operations...). Don't have time to delve in the C code
right now to confirm this; I'll have a look later if Bill doesn't beat
me to it :-)
Cheers,
K.B.
* Charles Greathouse [2023-08-26 15:36]:
> I don’t see it on version 2.16.1, df828f1c94.
>
> On Sat, Aug 26, 2023 at 9:04 AM Ruud H.G. van Tol <rvtol@isolution.nl>
> wrote:
>
> >
> > ? version()
> > % [2, 15, 4]
> >
> > ? my(L=List()); listput(L,1);
> > *** bug in simplify_shallow, type unknown, please report.
> >
> > -- Ruud
> >
> >
> >
K.B.
--
Pr. Karim Belabas, U. Bordeaux, Vice-président en charge du Numérique
Institut de Mathématiques de Bordeaux UMR 5251 - (+33) 05 40 00 29 77
http://www.math.u-bordeaux.fr/~kbelabas/