|Bill Allombert on Thu, 29 Oct 2015 18:24:17 +0100|
[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]
|Re: Faster digits and fromdigits in base 2^k, and FlxqM_mul_Kronecker|
On Thu, Oct 29, 2015 at 01:40:20PM +0100, Peter Bruin wrote: > Hi Bill, > > > However > > make test-digits > > fails > > and > > ? fromdigits([1,0,1],2) > > %1 = 7 > > is not good. > > > > the line 166 in fromdigits_2k > > if (k == 1) return bits_to_int(x, l); > > > > does not seem correct. > > You are right; I added this line at a late stage, and somehow > misunderstood bits_to_int. It should be in nv_fromdigits_2k instead > of fromdigits_2k. > > > PS: next time, you might want to look at 'git format-patch' to > > generate the patches. > > Also, you should try 'make checkspaces'. > > Thanks for the hints. I replaced the tabs by spaces and made new > patches using git format-patch. The difference with respect to the > previous ones is just the whitespace fixes and moving the call to > bits_to_int. Thanks, I have applied both patches. I will rename binary_2k_zv to binary_2k_nv Cheers, Bill.