Karim Belabas on Sat, 18 Dec 2010 02:08:32 +0100


[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: PATCH: gequal1 and gequal_1 for t_SERs


* Jeroen Demeyer [2009-05-11 11:22]:
> Bill Allombert wrote:
> >On Tue, Feb 10, 2009 at 12:09:22PM +0100, Jeroen Demeyer wrote:
> >>Hello pari-dev,
> >>
> >>It seems that gcmp1() and gcmp_1() were not implemented for
> >>t_SER (they always returned 0).  This patch should fix that.
> >>
> >>CHANGES:
> >>- Implemented gcmp1() and gcmp_1() for t_SERs.
[...]
> I am opening this thread again since there haven't been any replies...
> 
> Do you think there are any problems with this patch?  If there
> aren't, then you should commit it to SVN.  Maybe there are some
> (unrelated) problems with gequal(), but at least I think that this
> patch is an improvement over the current situation where
> gequal(1+O(t^10), 1) returns 1 but gequal1(1+O(t^10)) returns 0.

Hi Jeroen, sorry for the delay...

  I rewrote your patch from scratch to avoid code duplication and
(hopefully) catch up all instances of t_SER and t_POL that we would
like to "equal" to +/-1, for instance 0.0/x + 1 + O(x).

Committed to svn.

Thanks !

    K.B.
--
Karim Belabas, IMB (UMR 5251)  Tel: (+33) (0)5 40 00 26 17
Universite Bordeaux 1          Fax: (+33) (0)5 40 00 69 50
351, cours de la Liberation    http://www.math.u-bordeaux1.fr/~belabas/
F-33405 Talence (France)       http://pari.math.u-bordeaux1.fr/  [PARI/GP]
`