Re: [PATCH oldish CVS] readline 1.0

[Karim BELABAS <Karim.Belabas@math.u-psud.fr>]

On Mon, 10 Mar 2003, Ilya Zakharevich wrote:

> On Mon, Mar 10, 2003 at 10:46:20PM +0100, Karim BELABAS wrote:
>
> > > >  d) Report both version of readline at compile time and now (if possible);
>
> > What code exactly is missing ?
>
> The user-visible part is "d" (above) and it is done in two gp/gp.c
> chunks.  They look missing.
>
> The purpose of the code is to print the version in readline.h
> (calculated at compile time), and the version in
> readline.a/readline.so ("calculated" at link or run time
> correspondingly).  This makes it much easier to spot discrepancies/problems.

I think I included them:

% cvs log -r1.168 src/gp/gp.c
[...]
revision 1.168
date: 2002/12/15 15:32:23;  author: karim;  state: Exp;  lines: +25 -4
IZ 59- [readline:] support old versions (1.0), try to recover from
       mismatched headers wrt. library, report version of loaded library in
       gp header [as opposed to library version at Configure time]

The corresponding code reads:

   if (strcmp(READLINE, rl_library_version))
    {
      ver = (char*)rl_library_version;
      sprintf(extra, " [was v%s in Configure]", READLINE);
    }
    else
    ...

Anything missing ?

    Karim.
-- 
Karim Belabas                     Tel: (+33) (0)1 69 15 57 48
Dép. de Mathématiques, Bât. 425   Fax: (+33) (0)1 69 15 60 19
Université Paris-Sud              http://www.math.u-psud.fr/~belabas/
F-91405 Orsay (France)            http://www.parigp-home.de/  [PARI/GP]