Code coverage tests

This page documents the degree to which the PARI/GP source code is tested by our public test suite, distributed with the source distribution in directory src/test/. This is measured by the gcov utility; we then process gcov output using the lcov frond-end.

We test a few variants depending on Configure flags on the pari.math.u-bordeaux.fr machine (x86_64 architecture), and agregate them in the final report:

The target is 90% coverage for all mathematical modules (given that branches depending on DEBUGLEVEL or DEBUGMEM are not covered). This script is run to produce the results below.

LCOV - code coverage report
Current view: top level - modules - kummer.c (source / functions) Hit Total Coverage
Test: PARI/GP v2.8.0 lcov report (development 19217-a6dcf64) Lines: 721 838 86.0 %
Date: 2016-07-27 07:10:32 Functions: 51 56 91.1 %
Legend: Lines: hit not hit

          Line data    Source code
       1             : /* Copyright (C) 2000  The PARI group.
       2             : 
       3             : This file is part of the PARI/GP package.
       4             : 
       5             : PARI/GP is free software; you can redistribute it and/or modify it under the
       6             : terms of the GNU General Public License as published by the Free Software
       7             : Foundation. It is distributed in the hope that it will be useful, but WITHOUT
       8             : ANY WARRANTY WHATSOEVER.
       9             : 
      10             : Check the License for details. You should have received a copy of it, along
      11             : with the package; see the file 'COPYING'. If not, write to the Free Software
      12             : Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */
      13             : 
      14             : /*******************************************************************/
      15             : /*                                                                 */
      16             : /*                      KUMMER EXTENSIONS                          */
      17             : /*                                                                 */
      18             : /*******************************************************************/
      19             : #include "pari.h"
      20             : #include "paripriv.h"
      21             : 
      22             : typedef struct {
      23             :   GEN R; /* nf.pol */
      24             :   GEN x; /* tau ( Mod(x, R) ) */
      25             :   GEN zk;/* action of tau on nf.zk (as t_MAT) */
      26             : } tau_s;
      27             : 
      28             : typedef struct {
      29             :   GEN polnf, invexpoteta1, powg;
      30             :   tau_s *tau;
      31             :   long m;
      32             : } toK_s;
      33             : 
      34             : typedef struct {
      35             :   GEN R; /* ZX, compositum(P,Q) */
      36             :   GEN p; /* QX, Mod(p,R) root of P */
      37             :   GEN q; /* QX, Mod(q,R) root of Q */
      38             :   long k; /* Q[X]/R generated by q + k p */
      39             :   GEN rev;
      40             : } compo_s;
      41             : 
      42             : static long
      43         861 : prank(GEN cyc, long ell)
      44             : {
      45             :   long i;
      46        2485 :   for (i=1; i<lg(cyc); i++)
      47        1883 :     if (smodis(gel(cyc,i),ell)) break;
      48         861 :   return i-1;
      49             : }
      50             : 
      51             : /* increment y, which runs through [0,d-1]^(k-1). Return 0 when done. */
      52             : static int
      53         112 : increment(GEN y, long k, long d)
      54             : {
      55         112 :   long i = k, j;
      56             :   do
      57             :   {
      58         154 :     if (--i == 0) return 0;
      59         126 :     y[i]++;
      60         126 :   } while (y[i] >= d);
      61          84 :   for (j = i+1; j < k; j++) y[j] = 0;
      62          84 :   return 1;
      63             : }
      64             : 
      65             : static int
      66         399 : ok_congruence(GEN X, ulong ell, long lW, GEN vecMsup)
      67             : {
      68             :   long i, l;
      69         399 :   if (zv_equal0(X)) return 0;
      70         399 :   l = lg(X);
      71         721 :   for (i=lW; i<l; i++)
      72         343 :     if (X[i] == 0) return 0;
      73         378 :   l = lg(vecMsup);
      74         602 :   for (i=1; i<l; i++)
      75         245 :     if (zv_equal0(Flm_Flc_mul(gel(vecMsup,i),X, ell))) return 0;
      76         357 :   return 1;
      77             : }
      78             : 
      79             : static int
      80         105 : ok_sign(GEN X, GEN msign, GEN arch)
      81             : {
      82         105 :   return zv_equal(Flm_Flc_mul(msign, X, 2), arch);
      83             : }
      84             : 
      85             : /* REDUCTION MOD ell-TH POWERS */
      86             : 
      87             : #if 0
      88             : static GEN
      89             : logarch2arch(GEN x, long r1, long prec)
      90             : {
      91             :   long i, lx;
      92             :   GEN y = cgetg_copy(x, &lx);
      93             :   if (typ(x) == t_MAT)
      94             :   {
      95             :     for (i=1; i<lx; i++) gel(y,i) = logarch2arch(gel(x,i), r1, prec);
      96             :   }
      97             :   else
      98             :   {
      99             :     for (i=1; i<=r1;i++) gel(y,i) = gexp(gel(x,i),prec);
     100             :     for (   ; i<lx; i++) gel(y,i) = gexp(gmul2n(gel(x,i),-1),prec);
     101             :   }
     102             :   return y;
     103             : }
     104             : #endif
     105             : 
     106             : static GEN
     107         490 : reduce_mod_Qell(GEN bnfz, GEN be, GEN gell)
     108             : {
     109             :   GEN c;
     110         490 :   be = nf_to_scalar_or_basis(bnfz, be);
     111         490 :   be = Q_primitive_part(be, &c);
     112         490 :   if (c)
     113             :   {
     114         350 :     GEN d, fa = factor(c);
     115         350 :     gel(fa,2) = FpC_red(gel(fa,2), gell);
     116         350 :     d = factorback(fa);
     117         350 :     be = typ(be) == t_INT? mulii(be,d): ZC_Z_mul(be, d);
     118             :   }
     119         490 :   return be;
     120             : }
     121             : 
     122             : /* return q, q^n r = x, v_pr(r) < n for all pr. Insist q is a genuine n-th
     123             :  * root (i.e r = 1) if strict != 0. */
     124             : GEN
     125        1148 : idealsqrtn(GEN nf, GEN x, GEN gn, int strict)
     126             : {
     127        1148 :   long i, l, n = itos(gn);
     128             :   GEN fa, q, Ex, Pr;
     129             : 
     130        1148 :   fa = idealfactor(nf, x);
     131        1148 :   Pr = gel(fa,1); l = lg(Pr);
     132        1148 :   Ex = gel(fa,2); q = NULL;
     133        3850 :   for (i=1; i<l; i++)
     134             :   {
     135        2702 :     long ex = itos(gel(Ex,i));
     136        2702 :     GEN e = stoi(ex / n);
     137        2702 :     if (strict && ex % n) pari_err_SQRTN("idealsqrtn", fa);
     138        2702 :     if (q) q = idealmulpowprime(nf, q, gel(Pr,i), e);
     139         406 :     else   q = idealpow(nf, gel(Pr,i), e);
     140             :   }
     141        1148 :   return q? q: gen_1;
     142             : }
     143             : 
     144             : static GEN
     145         322 : reducebeta(GEN bnfz, GEN be, GEN ell)
     146             : {
     147         322 :   long prec = nf_get_prec(bnfz);
     148         322 :   GEN y, elllogfu, nf = bnf_get_nf(bnfz), fu = bnf_get_fu_nocheck(bnfz);
     149             : 
     150         322 :   if (DEBUGLEVEL>1) err_printf("reducing beta = %Ps\n",be);
     151             :   /* reduce mod Q^ell */
     152         322 :   be = reduce_mod_Qell(nf, be, ell);
     153             :   /* reduce l-th root */
     154         322 :   y = idealsqrtn(nf, be, ell, 0);
     155         322 :   if (typ(y) == t_MAT && !is_pm1(gcoeff(y,1,1)))
     156             :   {
     157         168 :     y = idealred_elt(nf, y);
     158         168 :     be = nfdiv(nf, be, nfpow(nf, y, ell));
     159             :     /* make be integral */
     160         168 :     be = reduce_mod_Qell(nf, be, ell);
     161             :   }
     162         322 :   if (DEBUGLEVEL>1) err_printf("beta reduced via ell-th root = %Ps\n",be);
     163             :   /* log. embeddings of fu^ell */
     164         322 :   elllogfu = RgM_Rg_mul(real_i(bnf_get_logfu(bnfz)), ell);
     165             :   for (;;)
     166             :   {
     167         343 :     GEN emb, z = get_arch_real(nf, be, &emb, prec);
     168         343 :     if (z)
     169             :     {
     170         322 :       GEN ex = RgM_Babai(elllogfu, z);
     171         322 :       if (ex)
     172             :       {
     173         322 :         be = nfdiv(nf, be, nffactorback(nf, fu, RgC_Rg_mul(ex,ell)));
     174         322 :         break;
     175             :       }
     176             :     }
     177          21 :     prec = precdbl(prec);
     178          21 :     if (DEBUGLEVEL) pari_warn(warnprec,"reducebeta",prec);
     179          21 :     nf = nfnewprec_shallow(nf,prec);
     180          21 :   }
     181         322 :   if (DEBUGLEVEL>1) err_printf("beta LLL-reduced mod U^l = %Ps\n",be);
     182         322 :   return be;
     183             : }
     184             : 
     185             : static GEN
     186        1666 : tauofalg(GEN x, tau_s *tau) {
     187        1666 :   long tx = typ(x);
     188        1666 :   if (tx == t_POLMOD) { x = gel(x,2); tx = typ(x); }
     189        1666 :   if (tx == t_POL) x = RgX_RgXQ_eval(x, tau->x, tau->R);
     190        1666 :   return mkpolmod(x, tau->R);
     191             : }
     192             : 
     193             : static tau_s *
     194         231 : get_tau(tau_s *tau, GEN nf, compo_s *C, long g)
     195             : {
     196         231 :   GEN bas = nf_get_zk(nf), U, Uzk;
     197         231 :   long i, l = lg(bas);
     198             : 
     199             :   /* compute action of tau: q^g + kp */
     200         231 :   U = RgX_add(RgXQ_powu(C->q, g, C->R), RgX_muls(C->p, C->k));
     201         231 :   U = RgX_RgXQ_eval(C->rev, U, C->R);
     202             : 
     203         231 :   tau->x  = U;
     204         231 :   tau->R  = C->R;
     205         231 :   Uzk = cgetg(l, t_MAT);
     206        1603 :   for (i=1; i<l; i++)
     207        1372 :     gel(Uzk,i) = algtobasis(nf, tauofalg(gel(bas,i), tau));
     208         231 :   tau->zk = Uzk; return tau;
     209             : }
     210             : 
     211             : static GEN tauoffamat(GEN x, tau_s *tau);
     212             : 
     213             : static GEN
     214        9926 : tauofelt(GEN x, tau_s *tau)
     215             : {
     216        9926 :   switch(typ(x))
     217             :   {
     218        8554 :     case t_COL: return RgM_RgC_mul(tau->zk, x);
     219        1078 :     case t_MAT: return tauoffamat(x, tau);
     220         294 :     default: return tauofalg(x, tau);
     221             :   }
     222             : }
     223             : static GEN
     224        1246 : tauofvec(GEN x, tau_s *tau)
     225             : {
     226             :   long i, l;
     227        1246 :   GEN y = cgetg_copy(x, &l);
     228        1246 :   for (i=1; i<l; i++) gel(y,i) = tauofelt(gel(x,i), tau);
     229        1246 :   return y;
     230             : }
     231             : /* [x, tau(x), ..., tau^m(x)] */
     232             : static GEN
     233         630 : powtau(GEN x, long m, tau_s *tau)
     234             : {
     235         630 :   GEN y = cgetg(m+1, t_VEC);
     236             :   long i;
     237         630 :   gel(y,1) = x;
     238         630 :   for (i=2; i<=m; i++) gel(y,i) = tauofelt(gel(y,i-1), tau);
     239         630 :   return y;
     240             : }
     241             : /* x^lambda */
     242             : static GEN
     243         539 : lambdaofelt(GEN x, toK_s *T)
     244             : {
     245         539 :   tau_s *tau = T->tau;
     246         539 :   long i, m = T->m;
     247         539 :   GEN y = cgetg(1, t_MAT), powg = T->powg; /* powg[i] = g^i */
     248        1372 :   for (i=1; i<m; i++)
     249             :   {
     250         833 :     y = famat_mul(y, famat_pow(x, gel(powg,m-i)));
     251         833 :     x = tauofelt(x, tau);
     252             :   }
     253         539 :   return famat_mul(y, x);
     254             : }
     255             : static GEN
     256         448 : lambdaofvec(GEN x, toK_s *T)
     257             : {
     258             :   long i, l;
     259         448 :   GEN y = cgetg_copy(x, &l);
     260         448 :   for (i=1; i<l; i++) gel(y,i) = lambdaofelt(gel(x,i), T);
     261         448 :   return y;
     262             : }
     263             : 
     264             : static GEN
     265        1078 : tauoffamat(GEN x, tau_s *tau)
     266             : {
     267        1078 :   return mkmat2(tauofvec(gel(x,1), tau), gel(x,2));
     268             : }
     269             : 
     270             : static GEN
     271         140 : tauofideal(GEN id, tau_s *tau)
     272             : {
     273         140 :   return ZM_hnfmodid(RgM_mul(tau->zk, id), gcoeff(id, 1,1));
     274             : }
     275             : 
     276             : static int
     277         644 : isprimeidealconj(GEN nfz, GEN P, GEN Q, tau_s *tau)
     278             : {
     279         644 :   GEN p = pr_get_p(P);
     280         644 :   GEN x = pr_get_gen(P);
     281         644 :   if (!equalii(p, pr_get_p(Q))
     282         490 :    || pr_get_e(P) != pr_get_e(Q)
     283         490 :    || pr_get_f(P) != pr_get_f(Q)) return 0;
     284         483 :   if (ZV_equal(x, pr_get_gen(Q))) return 1;
     285             :   for(;;)
     286             :   {
     287        1295 :     if (ZC_prdvd(nfz,x,Q)) return 1;
     288         980 :     x = FpC_red(tauofelt(x, tau), p);
     289         980 :     if (ZC_prdvd(nfz,x,P)) return 0;
     290         812 :   }
     291             : }
     292             : 
     293             : static int
     294         980 : isconjinprimelist(GEN nfz, GEN S, GEN pr, tau_s *tau)
     295             : {
     296             :   long i, l;
     297             : 
     298         980 :   if (!tau) return 0;
     299         756 :   l = lg(S);
     300        1085 :   for (i=1; i<l; i++)
     301         644 :     if (isprimeidealconj(nfz, gel(S,i),pr,tau)) return 1;
     302         441 :   return 0;
     303             : }
     304             : 
     305             : /* assume x in basistoalg form */
     306             : static GEN
     307        1036 : downtoK(toK_s *T, GEN x)
     308             : {
     309        1036 :   long degKz = lg(T->invexpoteta1) - 1;
     310        1036 :   GEN y = gmul(T->invexpoteta1, Rg_to_RgC(lift_intern(x), degKz));
     311        1036 :   return gmodulo(gtopolyrev(y,varn(T->polnf)), T->polnf);
     312             : }
     313             : 
     314             : static GEN
     315           0 : no_sol(long all, long i)
     316             : {
     317           0 :   if (!all) pari_err_BUG(stack_sprintf("kummer [bug%ld]", i));
     318           0 :   return cgetg(1,t_VEC);
     319             : }
     320             : 
     321             : static GEN
     322         308 : get_gell(GEN bnr, GEN subgp, long all)
     323             : {
     324             :   GEN gell;
     325         308 :   if (all && all != -1) return utoipos(labs(all));
     326         287 :   if (!subgp) return ZV_prod(bnr_get_cyc(bnr));
     327         287 :   gell = det(subgp);
     328         287 :   if (typ(gell) != t_INT) pari_err_TYPE("rnfkummer",gell);
     329         287 :   return gell;
     330             : }
     331             : 
     332             : typedef struct {
     333             :   GEN Sm, Sml1, Sml2, Sl, ESml2;
     334             : } primlist;
     335             : 
     336             : static int
     337         301 : build_list_Hecke(primlist *L, GEN nfz, GEN fa, GEN gothf, GEN gell, tau_s *tau)
     338             : {
     339             :   GEN listpr, listex, pr, factell;
     340         301 :   long vp, i, l, ell = itos(gell), degKz = nf_get_degree(nfz);
     341             : 
     342         301 :   if (!fa) fa = idealfactor(nfz, gothf);
     343         301 :   listpr = gel(fa,1);
     344         301 :   listex = gel(fa,2); l = lg(listpr);
     345         301 :   L->Sm  = vectrunc_init(l);
     346         301 :   L->Sml1= vectrunc_init(l);
     347         301 :   L->Sml2= vectrunc_init(l);
     348         301 :   L->Sl  = vectrunc_init(l+degKz);
     349         301 :   L->ESml2=vecsmalltrunc_init(l);
     350        1050 :   for (i=1; i<l; i++)
     351             :   {
     352         749 :     pr = gel(listpr,i);
     353         749 :     vp = itos(gel(listex,i));
     354         749 :     if (!equalii(pr_get_p(pr), gell))
     355             :     {
     356         574 :       if (vp != 1) return 1;
     357         574 :       if (!isconjinprimelist(nfz, L->Sm,pr,tau)) vectrunc_append(L->Sm,pr);
     358             :     }
     359             :     else
     360             :     {
     361         175 :       long e = pr_get_e(pr), vd = (vp-1)*(ell-1)-ell*e;
     362         175 :       if (vd > 0) return 4;
     363         175 :       if (vd==0)
     364             :       {
     365           7 :         if (!isconjinprimelist(nfz, L->Sml1,pr,tau)) vectrunc_append(L->Sml1, pr);
     366             :       }
     367             :       else
     368             :       {
     369         168 :         if (vp==1) return 2;
     370         168 :         if (!isconjinprimelist(nfz, L->Sml2,pr,tau))
     371             :         {
     372         168 :           vectrunc_append(L->Sml2, pr);
     373         168 :           vecsmalltrunc_append(L->ESml2, vp);
     374             :         }
     375             :       }
     376             :     }
     377             :   }
     378         301 :   factell = idealprimedec(nfz,gell); l = lg(factell);
     379         707 :   for (i=1; i<l; i++)
     380             :   {
     381         406 :     pr = gel(factell,i);
     382         406 :     if (!idealval(nfz,gothf,pr))
     383         231 :       if (!isconjinprimelist(nfz, L->Sl,pr,tau)) vectrunc_append(L->Sl, pr);
     384             :   }
     385         301 :   return 0; /* OK */
     386             : }
     387             : 
     388             : /* Return a Flm */
     389             : static GEN
     390         560 : logall(GEN nf, GEN vec, long lW, long mginv, long ell, GEN pr, long ex)
     391             : {
     392         560 :   GEN m, M, bid = Idealstar(nf, idealpows(nf, pr, ex), nf_INIT);
     393         560 :   long ellrank, i, l = lg(vec);
     394             : 
     395         560 :   ellrank = prank(bid_get_cyc(bid), ell);
     396         560 :   M = cgetg(l,t_MAT);
     397        2289 :   for (i=1; i<l; i++)
     398             :   {
     399        1729 :     m = ideallog(nf, gel(vec,i), bid);
     400        1729 :     setlg(m, ellrank+1);
     401        1729 :     if (i < lW) m = gmulsg(mginv, m);
     402        1729 :     gel(M,i) = ZV_to_Flv(m, ell);
     403             :   }
     404         560 :   return M;
     405             : }
     406             : 
     407             : /* compute the u_j (see remark 5.2.15.) */
     408             : static GEN
     409         301 : get_u(GEN cyc, long rc, GEN gell)
     410             : {
     411         301 :   long i, l = lg(cyc);
     412         301 :   GEN u = cgetg(l,t_VEC);
     413         301 :   for (i=1; i<=rc; i++) gel(u,i) = gen_0;
     414         301 :   for (   ; i<  l; i++) gel(u,i) = Fp_inv(gel(cyc,i), gell);
     415         301 :   return u;
     416             : }
     417             : 
     418             : /* alg. 5.2.15. with remark */
     419             : static GEN
     420         413 : isprincipalell(GEN bnfz, GEN id, GEN cycgen, GEN u, GEN gell, long rc)
     421             : {
     422         413 :   long i, l = lg(cycgen);
     423         413 :   GEN logdisc, b, y = bnfisprincipal0(bnfz, id, nf_FORCE|nf_GENMAT);
     424             : 
     425         413 :   logdisc = FpC_red(gel(y,1), gell);
     426         413 :   b = gel(y,2);
     427         609 :   for (i=rc+1; i<l; i++)
     428             :   {
     429         196 :     GEN e = modii(mulii(gel(logdisc,i),gel(u,i)), gell);
     430         196 :     if (signe(e)) b = famat_mul(b, famat_pow(gel(cycgen,i), e));
     431             :   }
     432         413 :   setlg(logdisc,rc+1); return mkvec2(logdisc, b);
     433             : }
     434             : 
     435             : static GEN
     436        1218 : famat_factorback(GEN v, GEN e)
     437             : {
     438        1218 :   long i, l = lg(e);
     439        1218 :   GEN V = cgetg(1, t_MAT);
     440        4305 :   for (i=1; i<l; i++)
     441        3087 :     if (signe(gel(e,i))) V = famat_mul(V, famat_pow(gel(v,i), gel(e,i)));
     442        1218 :   return V;
     443             : }
     444             : 
     445             : static GEN
     446         322 : compute_beta(GEN X, GEN vecWB, GEN ell, GEN bnfz)
     447             : {
     448             :   GEN BE, be;
     449         322 :   BE = famat_reduce(famat_factorback(vecWB, zv_to_ZV(X)));
     450         322 :   gel(BE,2) = centermod(gel(BE,2), ell);
     451         322 :   be = nffactorback(bnfz, BE, NULL);
     452         322 :   be = reducebeta(bnfz, be, ell);
     453         322 :   if (DEBUGLEVEL>1) err_printf("beta reduced = %Ps\n",be);
     454         322 :   return be;
     455             : }
     456             : 
     457             : static GEN
     458         301 : get_Selmer(GEN bnf, GEN cycgen, long rc)
     459             : {
     460         301 :   GEN fu = bnf_get_fu_nocheck(bnf), tu = bnf_get_tuU(bnf);
     461         301 :   GEN units = matalgtobasis(bnf,shallowconcat(fu,tu));
     462         301 :   return shallowconcat(units, vecslice(cycgen,1,rc));
     463             : }
     464             : 
     465             : GEN
     466       18613 : lift_if_rational(GEN x)
     467             : {
     468             :   long lx, i;
     469             :   GEN y;
     470             : 
     471       18613 :   switch(typ(x))
     472             :   {
     473        2373 :     default: break;
     474             : 
     475             :     case t_POLMOD:
     476       11039 :       y = gel(x,2);
     477       11039 :       if (typ(y) == t_POL)
     478             :       {
     479        2772 :         long d = degpol(y);
     480        2772 :         if (d > 0) return x;
     481         658 :         return (d < 0)? gen_0: gel(y,2);
     482             :       }
     483        8267 :       return y;
     484             : 
     485        2121 :     case t_POL: lx = lg(x);
     486        2121 :       for (i=2; i<lx; i++) gel(x,i) = lift_if_rational(gel(x,i));
     487        2121 :       break;
     488        3080 :     case t_VEC: case t_COL: case t_MAT: lx = lg(x);
     489        3080 :       for (i=1; i<lx; i++) gel(x,i) = lift_if_rational(gel(x,i));
     490             :   }
     491        7574 :   return x;
     492             : }
     493             : 
     494             : /* A column vector representing a subgroup of prime index */
     495             : static GEN
     496           0 : grptocol(GEN H)
     497             : {
     498           0 :   long i, j, l = lg(H);
     499           0 :   GEN col = cgetg(l, t_VECSMALL);
     500           0 :   for (i = 1; i < l; i++)
     501             :   {
     502           0 :     ulong ell = itou( gcoeff(H,i,i) );
     503           0 :     if (ell == 1) col[i] = 0; else { col[i] = ell-1; break; }
     504             :   }
     505           0 :   for (j=i; ++j < l; ) col[j] = itou( gcoeff(H,i,j) );
     506           0 :   return col;
     507             : }
     508             : 
     509             : /* Reorganize kernel basis so that the tests of ok_congruence can be ok
     510             :  * for y[ncyc]=1 and y[1..ncyc]=1 */
     511             : static GEN
     512           0 : fix_kernel(GEN K, GEN M, GEN vecMsup, long lW, long ell)
     513             : {
     514           0 :   pari_sp av = avma;
     515           0 :   long i, j, idx, ffree, dK = lg(K)-1;
     516           0 :   GEN Ki, Kidx = cgetg(dK+1, t_VECSMALL);
     517             : 
     518             :   /* First step: Gauss elimination on vectors lW...lg(M) */
     519           0 :   for (idx = lg(K), i=lg(M); --i >= lW; )
     520             :   {
     521           0 :     for (j=dK; j > 0; j--) if (coeff(K, i, j)) break;
     522           0 :     if (!j)
     523             :     { /* Do our best to ensure that K[dK,i] != 0 */
     524           0 :       if (coeff(K, i, dK)) continue;
     525           0 :       for (j = idx; j < dK; j++)
     526           0 :         if (coeff(K, i, j) && coeff(K, Kidx[j], dK) != ell - 1)
     527           0 :           Flv_add_inplace(gel(K,dK), gel(K,j), ell);
     528             :     }
     529           0 :     if (j != --idx) swap(gel(K, j), gel(K, idx));
     530           0 :     Kidx[idx] = i;
     531           0 :     if (coeff(K,i,idx) != 1)
     532           0 :       Flv_Fl_div_inplace(gel(K,idx), coeff(K,i,idx), ell);
     533           0 :     Ki = gel(K,idx);
     534           0 :     if (coeff(K,i,dK) != 1)
     535             :     {
     536           0 :       ulong t = Fl_sub(coeff(K,i,dK), 1, ell);
     537           0 :       Flv_sub_inplace(gel(K,dK), Flv_Fl_mul(Ki, t, ell), ell);
     538             :     }
     539           0 :     for (j = dK; --j > 0; )
     540             :     {
     541           0 :       if (j == idx) continue;
     542           0 :       if (coeff(K,i,j))
     543           0 :         Flv_sub_inplace(gel(K,j), Flv_Fl_mul(Ki, coeff(K,i,j), ell), ell);
     544             :     }
     545             :   }
     546             :   /* ffree = first vector that is not "free" for the scalar products */
     547           0 :   ffree = idx;
     548             :   /* Second step: for each hyperplane equation in vecMsup, do the same
     549             :    * thing as before. */
     550           0 :   for (i=1; i < lg(vecMsup); i++)
     551             :   {
     552           0 :     GEN Msup = gel(vecMsup,i);
     553             :     ulong dotprod;
     554           0 :     if (lgcols(Msup) != 2) continue;
     555           0 :     Msup = zm_row(Msup, 1);
     556           0 :     for (j=ffree; --j > 0; )
     557             :     {
     558           0 :       dotprod = Flv_dotproduct(Msup, gel(K,j), ell);
     559           0 :       if (dotprod)
     560             :       {
     561           0 :         if (j != --ffree) swap(gel(K, j), gel(K, ffree));
     562           0 :         if (dotprod != 1) Flv_Fl_div_inplace(gel(K, ffree), dotprod, ell);
     563           0 :         break;
     564             :       }
     565             :     }
     566           0 :     if (!j)
     567             :     { /* Do our best to ensure that vecMsup.K[dK] != 0 */
     568           0 :       if (Flv_dotproduct(Msup, gel(K,dK), ell) == 0)
     569             :       {
     570           0 :         for (j = ffree-1; j <= dK; j++)
     571           0 :           if (Flv_dotproduct(Msup, gel(K,j), ell)
     572           0 :               && coeff(K,Kidx[j],dK) != ell-1)
     573           0 :             Flv_add_inplace(gel(K,dK), gel(K,j), ell);
     574             :       }
     575           0 :       continue;
     576             :     }
     577           0 :     Ki = gel(K,ffree);
     578           0 :     dotprod = Flv_dotproduct(Msup, gel(K,dK), ell);
     579           0 :     if (dotprod != 1)
     580             :     {
     581           0 :       ulong t = Fl_sub(dotprod,1,ell);
     582           0 :       Flv_sub_inplace(gel(K,dK), Flv_Fl_mul(Ki,t,ell), ell);
     583             :     }
     584           0 :     for (j = dK; --j > 0; )
     585             :     {
     586           0 :       if (j == ffree) continue;
     587           0 :       dotprod = Flv_dotproduct(Msup, gel(K,j), ell);
     588           0 :       if (dotprod) Flv_sub_inplace(gel(K,j), Flv_Fl_mul(Ki,dotprod,ell), ell);
     589             :     }
     590             :   }
     591           0 :   if (ell == 2)
     592             :   {
     593           0 :     for (i = ffree, j = ffree-1; i <= dK && j; i++, j--)
     594           0 :     { swap(gel(K,i), gel(K,j)); }
     595             :   }
     596             :   /* Try to ensure that y = vec_ei(n, i) gives a good candidate */
     597           0 :   for (i = 1; i < dK; i++) Flv_add_inplace(gel(K,i), gel(K,dK), ell);
     598           0 :   return gerepilecopy(av, K);
     599             : }
     600             : 
     601             : static GEN
     602           0 : Flm_init(long m, long n)
     603             : {
     604           0 :   GEN M = cgetg(n+1, t_MAT);
     605           0 :   long i; for (i = 1; i <= n; i++) gel(M,i) = cgetg(m+1, t_VECSMALL);
     606           0 :   return M;
     607             : }
     608             : static void
     609           0 : Flv_fill(GEN v, GEN y)
     610             : {
     611           0 :   long i, l = lg(y);
     612           0 :   for (i = 1; i < l; i++) v[i] = y[i];
     613           0 : }
     614             : 
     615             : static GEN
     616         504 : get_badbnf(GEN bnf)
     617             : {
     618             :   long i, l;
     619         504 :   GEN bad = gen_1, gen = bnf_get_gen(bnf);
     620         504 :   l = lg(gen);
     621         945 :   for (i = 1; i < l; i++)
     622             :   {
     623         441 :     GEN g = gel(gen,i);
     624         441 :     bad = lcmii(bad, gcoeff(g,1,1));
     625             :   }
     626         504 :   return bad;
     627             : }
     628             : /* Let K base field, L/K described by bnr (conductor f) + H. Return a list of
     629             :  * primes coprime to f*ell of degree 1 in K whose images in Cl_f(K) generate H:
     630             :  * thus they all split in Lz/Kz; t in Kz is such that
     631             :  * t^(1/p) generates Lz => t is an ell-th power in k(pr) for all such primes.
     632             :  * Restrict to primes not dividing
     633             :  * - the index fz of the polynomial defining Kz, or
     634             :  * - the modulus, or
     635             :  * - ell, or
     636             :  * - a generator in bnf.gen or bnfz.gen */
     637             : static GEN
     638         287 : get_prlist(GEN bnr, GEN H, ulong ell, GEN bnfz)
     639             : {
     640         287 :   pari_sp av0 = avma;
     641             :   forprime_t T;
     642             :   ulong p;
     643             :   GEN L, nf, cyc, bad, cond, condZ, Hsofar;
     644         287 :   L = cgetg(1, t_VEC);
     645         287 :   cyc = bnr_get_cyc(bnr);
     646         287 :   nf = bnr_get_nf(bnr);
     647             : 
     648         287 :   cond = gel(bnr_get_mod(bnr), 1);
     649         287 :   condZ = gcoeff(cond,1,1);
     650         287 :   bad = get_badbnf(bnr_get_bnf(bnr));
     651         287 :   if (bnfz)
     652             :   {
     653         217 :     GEN badz = lcmii(get_badbnf(bnfz), nf_get_index(bnf_get_nf(bnfz)));
     654         217 :     bad = mulii(bad,badz);
     655             :   }
     656         287 :   bad = lcmii(muliu(condZ, ell), bad);
     657             :   /* restrict to primes not dividing bad */
     658             : 
     659         287 :   u_forprime_init(&T, 2, ULONG_MAX);
     660         287 :   Hsofar = cgetg(1, t_MAT);
     661        6167 :   while ((p = u_forprime_next(&T)))
     662             :   {
     663             :     GEN LP;
     664             :     long i, l;
     665        5880 :     if (p == ell || !umodiu(bad, p)) continue;
     666        4914 :     LP = idealprimedec_limit_f(nf, utoipos(p), 1);
     667        4914 :     l = lg(LP);
     668        8043 :     for (i = 1; i < l; i++)
     669             :     {
     670        3416 :       pari_sp av = avma;
     671        3416 :       GEN M, P = gel(LP,i), v = bnrisprincipal(bnr, P, 0);
     672        3416 :       if (!hnf_invimage(H, v)) { avma = av; continue; }
     673         805 :       M = shallowconcat(Hsofar, v);
     674         805 :       M = ZM_hnfmodid(M, cyc);
     675         805 :       if (ZM_equal(M, Hsofar)) continue;
     676         511 :       L = shallowconcat(L, mkvec(P));
     677         511 :       Hsofar = M;
     678             :       /* the primes in L generate H */
     679         511 :       if (ZM_equal(M, H)) return gerepilecopy(av0, L);
     680             :     }
     681             :   }
     682           0 :   pari_err_BUG("rnfkummer [get_prlist]");
     683           0 :   return NULL;
     684             : }
     685             : /*Lprz list of prime ideals in Kz that must split completely in Lz/Kz, vecWA
     686             :  * generators for the S-units used to build the Kummer generators. Return
     687             :  * matsmall M such that \prod WA[j]^x[j] ell-th power mod pr[i] iff
     688             :  * \sum M[i,j] x[j] = 0 (mod ell) */
     689             : static GEN
     690         287 : subgroup_info(GEN bnfz, GEN Lprz, long ell, GEN vecWA)
     691             : {
     692         287 :   GEN nfz = bnf_get_nf(bnfz), M, gell = utoipos(ell), Lell = mkvec(gell);
     693         287 :   long i, j, l = lg(vecWA), lz = lg(Lprz);
     694         287 :   M = cgetg(l, t_MAT);
     695         287 :   for (j=1; j<l; j++) gel(M,j) = cgetg(lz, t_VECSMALL);
     696         798 :   for (i=1; i < lz; i++)
     697             :   {
     698         511 :     GEN pr = gel(Lprz,i), EX = subiu(pr_norm(pr), 1);
     699         511 :     GEN N, g,T,p, prM = idealhnf(nfz, pr);
     700         511 :     GEN modpr = zk_to_Fq_init(nfz, &pr,&T,&p);
     701         511 :     long v = Z_lvalrem(divis(EX,ell), ell, &N) + 1; /* Norm(pr)-1 = N * ell^v */
     702         511 :     GEN ellv = powuu(ell, v);
     703         511 :     g = gener_Fq_local(T,p, Lell);
     704         511 :     g = Fq_pow(g,N, T,p); /* order ell^v */
     705        2387 :     for (j=1; j < l; j++)
     706             :     {
     707        1876 :       GEN logc, c = gel(vecWA,j);
     708        1876 :       if (typ(c) == t_MAT) /* famat */
     709        1078 :         c = famat_makecoprime(nfz, gel(c,1), gel(c,2), pr, prM, EX);
     710        1876 :       c = nf_to_Fq(nfz, c, modpr);
     711        1876 :       c = Fq_pow(c, N, T,p);
     712        1876 :       logc = Fq_log(c, g, ellv, T,p);
     713        1876 :       ucoeff(M, i,j) = umodiu(logc, ell);
     714             :     }
     715             :   }
     716         287 :   return M;
     717             : }
     718             : 
     719             : /* if all!=0, give all equations of degree 'all'. Assume bnr modulus is the
     720             :  * conductor */
     721             : static GEN
     722          70 : rnfkummersimple(GEN bnr, GEN subgroup, GEN gell, long all)
     723             : {
     724             :   long ell, i, j, degK, dK;
     725             :   long lSml2, lSl2, lSp, rc, lW;
     726             :   long prec;
     727          70 :   long rk=0, ncyc=0;
     728          70 :   GEN mat=NULL, matgrp=NULL, xell, be1 = NULL;
     729          70 :   long firstpass = all<0;
     730             : 
     731             :   GEN bnf,nf,bid,ideal,arch,cycgen;
     732             :   GEN cyc;
     733             :   GEN Sp,listprSp,matP;
     734          70 :   GEN res=NULL,u,M,K,y,vecMsup,vecW,vecWB,vecBp,msign;
     735             :   primlist L;
     736             : 
     737          70 :   bnf = bnr_get_bnf(bnr); (void)bnf_get_fu(bnf);
     738          70 :   nf  = bnf_get_nf(bnf);
     739          70 :   degK = nf_get_degree(nf);
     740             : 
     741          70 :   bid = bnr_get_bid(bnr);
     742          70 :   ideal= bid_get_ideal(bid);
     743          70 :   arch = bid_get_arch(bid); /* this is the conductor */
     744          70 :   ell = itos(gell);
     745          70 :   i = build_list_Hecke(&L, nf, gel(bid,3), ideal, gell, NULL);
     746          70 :   if (i) return no_sol(all,i);
     747             : 
     748          70 :   lSml2 = lg(L.Sml2)-1;
     749          70 :   Sp = shallowconcat(L.Sm, L.Sml1); lSp = lg(Sp)-1;
     750          70 :   listprSp = shallowconcat(L.Sml2, L.Sl); lSl2 = lg(listprSp)-1;
     751             : 
     752          70 :   cycgen = check_and_build_cycgen(bnf);
     753          70 :   cyc = bnf_get_cyc(bnf); rc = prank(cyc, ell);
     754             : 
     755          70 :   vecW = get_Selmer(bnf, cycgen, rc);
     756          70 :   u = get_u(cyc, rc, gell);
     757             : 
     758          70 :   vecBp = cgetg(lSp+1, t_VEC);
     759          70 :   matP  = cgetg(lSp+1, t_MAT);
     760         189 :   for (j=1; j<=lSp; j++)
     761             :   {
     762         119 :     GEN L = isprincipalell(bnf,gel(Sp,j), cycgen,u,gell,rc);
     763         119 :     gel( matP,j) = gel(L,1);
     764         119 :     gel(vecBp,j) = gel(L,2);
     765             :   }
     766          70 :   vecWB = shallowconcat(vecW, vecBp);
     767             : 
     768          70 :   prec = DEFAULTPREC +
     769          70 :       nbits2extraprec(((degK-1) * (gexpo(vecWB) + gexpo(nf_get_M(nf)))));
     770          70 :   if (nf_get_prec(nf) < prec) nf = nfnewprec_shallow(nf, prec);
     771          70 :   msign = nfsign(nf, vecWB);
     772          70 :   arch = ZV_to_zv(arch);
     773             : 
     774          70 :   vecMsup = cgetg(lSml2+1,t_VEC);
     775          70 :   M = NULL;
     776         175 :   for (i=1; i<=lSl2; i++)
     777             :   {
     778         105 :     GEN pr = gel(listprSp,i);
     779         105 :     long e = pr_get_e(pr), z = ell * (e / (ell-1));
     780             : 
     781         105 :     if (i <= lSml2)
     782             :     {
     783          35 :       z += 1 - L.ESml2[i];
     784          35 :       gel(vecMsup,i) = logall(nf, vecWB, 0,0, ell, pr,z+1);
     785             :     }
     786         105 :     M = vconcat(M, logall(nf, vecWB, 0,0, ell, pr,z));
     787             :   }
     788          70 :   lW = lg(vecW);
     789          70 :   M = vconcat(M, shallowconcat(zero_Flm(rc,lW-1), ZM_to_Flm(matP, ell)));
     790          70 :   if (!all)
     791             :   { /* primes landing in subgroup must be totally split */
     792          70 :     GEN Lpr = get_prlist(bnr, subgroup, ell, NULL);
     793          70 :     GEN M2 = subgroup_info(bnf, Lpr, ell, vecWB);
     794          70 :     M = vconcat(M, M2);
     795             :   }
     796          70 :   K = Flm_ker(M, ell);
     797          70 :   dK = lg(K)-1;
     798             : 
     799          70 :   if (all < 0)
     800           0 :     K = fix_kernel(K, M, vecMsup, lW, ell);
     801             : 
     802          70 :   y = cgetg(dK+1,t_VECSMALL);
     803          70 :   if (all) res = cgetg(1,t_VEC); /* in case all = 1 */
     804          70 :   if (all < 0)
     805             :   {
     806           0 :     ncyc = dK;
     807           0 :     mat = Flm_init(dK, ncyc);
     808           0 :     if (all == -1) matgrp = Flm_init(lg(bnr_get_cyc(bnr)), ncyc+1);
     809           0 :     rk = 0;
     810             :   }
     811          70 :   xell = monomial(gen_1, ell, 0);
     812             :   do {
     813          70 :     dK = lg(K)-1;
     814         147 :     while (dK)
     815             :     {
     816          77 :       for (i=1; i<dK; i++) y[i] = 0;
     817          77 :       y[i] = 1; /* y = [0,...,0,1,0,...,0], 1 at dK'th position */
     818             :       do
     819             :       {
     820         147 :         pari_sp av = avma;
     821         147 :         GEN be, P=NULL, X;
     822         147 :         if (all < 0)
     823             :         {
     824           0 :           Flv_fill(gel(mat, rk+1), y);
     825           0 :           setlg(mat, rk+2);
     826           0 :           if (Flm_rank(mat, ell) <= rk) continue;
     827             :         }
     828         147 : FOUND:  X = Flm_Flc_mul(K, y, ell);
     829         147 :         if (ok_congruence(X, ell, lW, vecMsup) && ok_sign(X, msign, arch))
     830             :         {/* be satisfies all congruences, x^ell - be is irreducible, signature
     831             :           * and relative discriminant are correct */
     832          70 :           if (all < 0) rk++;
     833          70 :           be = compute_beta(X, vecWB, gell, bnf);
     834          70 :           be = nf_to_scalar_or_alg(nf, be);
     835          70 :           if (typ(be) == t_POL) be = mkpolmod(be, nf_get_pol(nf));
     836          70 :           if (all == -1)
     837             :           {
     838           0 :             pari_sp av2 = avma;
     839           0 :             GEN Kgrp, colgrp = grptocol(rnfnormgroup(bnr, gsub(xell, be)));
     840           0 :             if (ell != 2)
     841             :             {
     842           0 :               if (rk == 1) be1 = be;
     843             :               else
     844             :               { /* Compute the pesky scalar */
     845           0 :                 GEN K2, C = cgetg(4, t_MAT);
     846           0 :                 gel(C,1) = gel(matgrp,1);
     847           0 :                 gel(C,2) = colgrp;
     848           0 :                 gel(C,3) = grptocol(rnfnormgroup(bnr, gsub(xell, gmul(be1,be))));
     849           0 :                 K2 = Flm_ker(C, ell);
     850           0 :                 if (lg(K2) != 2) pari_err_BUG("linear algebra");
     851           0 :                 K2 = gel(K2,1);
     852           0 :                 if (K2[1] != K2[2])
     853           0 :                   Flv_Fl_mul_inplace(colgrp, Fl_div(K2[2],K2[1],ell), ell);
     854             :               }
     855             :             }
     856           0 :             Flv_fill(gel(matgrp,rk), colgrp);
     857           0 :             setlg(matgrp, rk+1);
     858           0 :             Kgrp = Flm_ker(matgrp, ell);
     859           0 :             if (lg(Kgrp) == 2)
     860             :             {
     861           0 :               setlg(gel(Kgrp,1), rk+1);
     862           0 :               y = Flm_Flc_mul(mat, gel(Kgrp,1), ell);
     863           0 :               all = 0; goto FOUND;
     864             :             }
     865           0 :             avma = av2;
     866             :           }
     867             :           else
     868             :           {
     869          70 :             P = gsub(xell, be);
     870          70 :             if (all)
     871           0 :               res = shallowconcat(res, gerepileupto(av, P));
     872             :             else
     873             :             {
     874          70 :               if (ZM_equal(rnfnormgroup(bnr,P),subgroup)) return P; /*DONE*/
     875           0 :               avma = av; continue;
     876             :             }
     877             :           }
     878           0 :           if (all < 0 && rk == ncyc) return res;
     879           0 :           if (firstpass) break;
     880             :         }
     881          77 :         else avma = av;
     882          77 :       } while (increment(y, dK, ell));
     883           7 :       y[dK--] = 0;
     884             :     }
     885           0 :   } while (firstpass--);
     886           0 :   return all? res: gen_0;
     887             : }
     888             : 
     889             : /* alg. 5.3.11 (return only discrete log mod ell) */
     890             : static GEN
     891         826 : isvirtualunit(GEN bnf, GEN v, GEN cycgen, GEN cyc, GEN gell, long rc)
     892             : {
     893         826 :   GEN L, b, eps, y, q, nf = bnf_get_nf(bnf);
     894         826 :   GEN w = idealsqrtn(nf, v, gell, 1);
     895         826 :   long i, l = lg(cycgen);
     896             : 
     897         826 :   L = bnfisprincipal0(bnf, w, nf_GENMAT|nf_FORCE);
     898         826 :   q = gel(L,1);
     899         826 :   if (gequal0(q)) { eps = v; y = q; }
     900             :   else
     901             :   {
     902         140 :     b = gel(L,2);
     903         140 :     y = cgetg(l,t_COL);
     904         420 :     for (i=1; i<l; i++)
     905         280 :       gel(y,i) = diviiexact(mulii(gell,gel(q,i)), gel(cyc,i));
     906         140 :     eps = famat_mul(famat_factorback(cycgen, y), famat_pow(b, gell));
     907         140 :     eps = famat_mul(famat_inv(eps), v);
     908             :   }
     909         826 :   setlg(y, rc+1);
     910         826 :   b = bnfisunit(bnf,eps);
     911         826 :   if (lg(b) == 1) pari_err_BUG("isvirtualunit");
     912         826 :   return shallowconcat(lift_intern(b), y);
     913             : }
     914             : 
     915             : /* J a vector of elements in nfz = relative extension of nf by polrel,
     916             :  * return the Steinitz element attached to the module generated by J */
     917             : static GEN
     918         651 : Stelt(GEN nf, GEN J, GEN polrel)
     919             : {
     920         651 :   long i, l = lg(J), vx = varn(polrel);
     921         651 :   GEN A = cgetg(l, t_VEC), I = cgetg(l, t_VEC);
     922        4487 :   for (i = 1; i < l; i++)
     923             :   {
     924        3836 :     GEN v = gel(J,i);
     925        3836 :     if (typ(v) == t_POL) { v = RgX_rem(v, polrel); setvarn(v,vx); }
     926        3836 :     gel(A,i) = v;
     927        3836 :     gel(I,i) = gen_1;
     928             :   }
     929         651 :   A = RgV_to_RgM(A, degpol(polrel));
     930         651 :   return prodid(nf, gel(nfhnf(nf, mkvec2(A,I)),2));
     931             : }
     932             : 
     933             : static GEN
     934         126 : polrelKzK(toK_s *T, GEN x)
     935             : {
     936         126 :   GEN P = roots_to_pol(powtau(x, T->m, T->tau), 0);
     937         126 :   long i, l = lg(P);
     938         126 :   for (i=2; i<l; i++) gel(P,i) = downtoK(T, gel(P,i));
     939         126 :   return P;
     940             : }
     941             : 
     942             : /* N: Cl_m(Kz) --> Cl_m(K), lift subgroup from bnr to bnrz using Algo 4.1.11 */
     943             : static GEN
     944         126 : invimsubgroup(GEN bnrz, GEN bnr, GEN subgroup, toK_s *T)
     945             : {
     946             :   long l, j;
     947             :   GEN P, cyc, gen, U, polrel, StZk;
     948         126 :   GEN nf = bnr_get_nf(bnr), nfz = bnr_get_nf(bnrz);
     949         126 :   GEN polz = nf_get_pol(nfz), zkz = nf_get_zk(nfz);
     950             : 
     951         126 :   polrel = polrelKzK(T, pol_x(varn(polz)));
     952         126 :   StZk = Stelt(nf, zkz, polrel);
     953         126 :   cyc = bnr_get_cyc(bnrz); l = lg(cyc);
     954         126 :   gen = bnr_get_gen(bnrz);
     955         126 :   P = cgetg(l,t_MAT);
     956         651 :   for (j=1; j<l; j++)
     957             :   {
     958         525 :     GEN g, id = idealhnf_shallow(nfz, gel(gen,j));
     959         525 :     g = Stelt(nf, RgV_RgM_mul(zkz, id), polrel);
     960         525 :     g = idealdiv(nf, g, StZk); /* N_{Kz/K}(gen[j]) */
     961         525 :     gel(P,j) = isprincipalray(bnr, g);
     962             :   }
     963         126 :   (void)ZM_hnfall(shallowconcat(P, subgroup), &U, 1);
     964         126 :   setlg(U, l); for (j=1; j<l; j++) setlg(U[j], l);
     965         126 :   return ZM_hnfmodid(U, cyc);
     966             : }
     967             : 
     968             : static GEN
     969         252 : pol_from_Newton(GEN S)
     970             : {
     971         252 :   long i, k, l = lg(S);
     972         252 :   GEN C = cgetg(l+1, t_VEC), c = C + 1;
     973         252 :   gel(c,0) = gen_1;
     974         252 :   gel(c,1) = gel(S,1); /* gen_0 in our case */
     975         882 :   for (k = 2; k < l; k++)
     976             :   {
     977         630 :     GEN s = gel(S,k);
     978         630 :     for (i = 2; i < k-1; i++) s = gadd(s, gmul(gel(S,i), gel(c,k-i)));
     979         630 :     gel(c,k) = gdivgs(s, -k);
     980             :   }
     981         252 :   return gtopoly(C, 0);
     982             : }
     983             : 
     984             : /* - mu_b = sum_{0 <= i < m} floor(r_b r_{d-1-i} / ell) tau^i */
     985             : static GEN
     986         602 : get_mmu(long b, GEN r, long ell)
     987             : {
     988         602 :   long i, m = lg(r)-1;
     989         602 :   GEN M = cgetg(m+1, t_VEC);
     990         602 :   for (i = 0; i < m; i++) gel(M,i+1) = stoi((r[b + 1] * r[m - i]) / ell);
     991         602 :   return M;
     992             : }
     993             : 
     994             : /* coeffs(x, a..b) in variable v >= varn(x) */
     995             : static GEN
     996        5964 : split_pol(GEN x, long v, long a, long b)
     997             : {
     998        5964 :   long i, l = degpol(x);
     999        5964 :   GEN y = x + a, z;
    1000             : 
    1001        5964 :   if (l < b) b = l;
    1002        5964 :   if (a > b || varn(x) != v) return pol_0(v);
    1003        5320 :   l = b-a + 3;
    1004        5320 :   z = cgetg(l, t_POL); z[1] = x[1];
    1005        5320 :   for (i = 2; i < l; i++) gel(z,i) = gel(y,i);
    1006        5320 :   return normalizepol_lg(z, l);
    1007             : }
    1008             : 
    1009             : /* return (den_a * z) mod (v^ell - num_a/den_a), assuming deg(z) < 2*ell
    1010             :  * allow either num/den to be NULL (= 1) */
    1011             : static GEN
    1012        2982 : mod_Xell_a(GEN z, long v, long ell, GEN num_a, GEN den_a)
    1013             : {
    1014        2982 :   GEN z1 = split_pol(z, v, ell, degpol(z));
    1015        2982 :   GEN z0 = split_pol(z, v, 0,   ell-1); /* z = v^ell z1 + z0*/
    1016        2982 :   if (den_a) z0 = gmul(den_a, z0);
    1017        2982 :   if (num_a) z1 = gmul(num_a, z1);
    1018        2982 :   return gadd(z0, z1);
    1019             : }
    1020             : static GEN
    1021         854 : to_alg(GEN nfz, GEN c, long v)
    1022             : {
    1023             :   GEN z;
    1024         854 :   if (typ(c) != t_COL) return c;
    1025         602 :   z = gmul(nf_get_zk(nfz), c);
    1026         602 :   if (typ(z) == t_POL) setvarn(z, v);
    1027         602 :   return z;
    1028             : }
    1029             : 
    1030             : /* th. 5.3.5. and prop. 5.3.9. */
    1031             : static GEN
    1032         252 : compute_polrel(GEN nfz, toK_s *T, GEN be, long g, long ell)
    1033             : {
    1034         252 :   long i, k, m = T->m, vT = fetch_var(), vz = fetch_var();
    1035             :   GEN r, powtaubet, S, p1, root, num_t, den_t, nfzpol, powtau_prim_invbe;
    1036             :   GEN prim_Rk, C_Rk, prim_root, C_root, prim_invbe, C_invbe;
    1037             :   pari_timer ti;
    1038             : 
    1039         252 :   r = cgetg(m+1,t_VECSMALL); /* r[i+1] = g^i mod ell */
    1040         252 :   r[1] = 1;
    1041         252 :   for (i=2; i<=m; i++) r[i] = (r[i-1] * g) % ell;
    1042         252 :   powtaubet = powtau(be, m, T->tau);
    1043         252 :   if (DEBUGLEVEL>1) { err_printf("Computing Newton sums: "); timer_start(&ti); }
    1044         252 :   prim_invbe = Q_primitive_part(nfinv(nfz, be), &C_invbe);
    1045         252 :   powtau_prim_invbe = powtau(prim_invbe, m, T->tau);
    1046             : 
    1047         252 :   root = cgetg(ell + 2, t_POL);
    1048         252 :   root[1] = evalsigne(1) | evalvarn(0);
    1049         252 :   for (i = 0; i < ell; i++) gel(root,2+i) = gen_0;
    1050         854 :   for (i = 0; i < m; i++)
    1051             :   { /* compute (1/be) ^ (-mu) instead of be^mu [mu << 0].
    1052             :      * 1/be = C_invbe * prim_invbe */
    1053         602 :     GEN mmu = get_mmu(i, r, ell);
    1054             :     /* p1 = prim_invbe ^ -mu */
    1055         602 :     p1 = to_alg(nfz, nffactorback(nfz, powtau_prim_invbe, mmu), vz);
    1056         602 :     if (C_invbe) p1 = gmul(p1, powgi(C_invbe, RgV_sumpart(mmu, m)));
    1057             :     /* root += zeta_ell^{r_i} T^{r_i} be^mu_i */
    1058         602 :     gel(root, 2 + r[i+1]) = monomial(p1, r[i+1], vT);
    1059             :   }
    1060             :   /* Other roots are as above with z_ell --> z_ell^j.
    1061             :    * Treat all contents (C_*) and principal parts (prim_*) separately */
    1062         252 :   prim_Rk = prim_root = Q_primitive_part(root, &C_root);
    1063         252 :   C_Rk = C_root;
    1064             : 
    1065         252 :   r = vecsmall_reverse(r); /* theta^ell = be^( sum tau^a r_{d-1-a} ) */
    1066             :   /* Compute modulo X^ell - 1, T^ell - t, nfzpol(vz) */
    1067         252 :   p1 = to_alg(nfz, nffactorback(nfz, powtaubet, r), vz);
    1068         252 :   num_t = Q_remove_denom(p1, &den_t);
    1069             : 
    1070         252 :   nfzpol = leafcopy(nf_get_pol(nfz));
    1071         252 :   setvarn(nfzpol, vz);
    1072         252 :   S = cgetg(ell+1, t_VEC); /* Newton sums */
    1073         252 :   gel(S,1) = gen_0;
    1074         882 :   for (k = 2; k <= ell; k++)
    1075             :   { /* compute the k-th Newton sum */
    1076         630 :     pari_sp av = avma;
    1077         630 :     GEN z, D, Rk = gmul(prim_Rk, prim_root);
    1078         630 :     C_Rk = mul_content(C_Rk, C_root);
    1079         630 :     Rk = mod_Xell_a(Rk, 0, ell, NULL, NULL); /* mod X^ell - 1 */
    1080        3010 :     for (i = 2; i < lg(Rk); i++)
    1081             :     {
    1082        2380 :       if (typ(gel(Rk,i)) != t_POL) continue;
    1083        2352 :       z = mod_Xell_a(gel(Rk,i), vT, ell, num_t,den_t); /* mod T^ell - t */
    1084        2352 :       gel(Rk,i) = RgXQX_red(z, nfzpol); /* mod nfz.pol */
    1085             :     }
    1086         630 :     if (den_t) C_Rk = mul_content(C_Rk, ginv(den_t));
    1087         630 :     prim_Rk = Q_primitive_part(Rk, &D);
    1088         630 :     C_Rk = mul_content(C_Rk, D); /* root^k = prim_Rk * C_Rk */
    1089             : 
    1090             :     /* Newton sum is ell * constant coeff (in X), which has degree 0 in T */
    1091         630 :     z = polcoeff_i(prim_Rk, 0, 0);
    1092         630 :     z = polcoeff_i(z      , 0,vT);
    1093         630 :     z = downtoK(T, gmulgs(z, ell));
    1094         630 :     if (C_Rk) z = gmul(z, C_Rk);
    1095         630 :     gerepileall(av, C_Rk? 3: 2, &z, &prim_Rk, &C_Rk);
    1096         630 :     if (DEBUGLEVEL>1) { err_printf("%ld(%ld) ", k, timer_delay(&ti)); err_flush(); }
    1097         630 :     gel(S,k) = z;
    1098             :   }
    1099         252 :   if (DEBUGLEVEL>1) err_printf("\n");
    1100         252 :   (void)delete_var();
    1101         252 :   (void)delete_var(); return pol_from_Newton(S);
    1102             : }
    1103             : 
    1104             : /* lift elt t in nf to nfz, algebraic form */
    1105             : static GEN
    1106         350 : lifttoKz(GEN nf, GEN t, compo_s *C)
    1107             : {
    1108         350 :   GEN x = nf_to_scalar_or_alg(nf, t);
    1109         350 :   if (typ(x) != t_POL) return x;
    1110         350 :   return RgX_RgXQ_eval(x, C->p, C->R);
    1111             : }
    1112             : /* lift ideal id in nf to nfz */
    1113             : static GEN
    1114         231 : ideallifttoKz(GEN nfz, GEN nf, GEN id, compo_s *C)
    1115             : {
    1116         231 :   GEN I = idealtwoelt(nf,id);
    1117         231 :   GEN x = nf_to_scalar_or_alg(nf, gel(I,2));
    1118         231 :   if (typ(x) != t_POL) return gel(I,1);
    1119         147 :   gel(I,2) = algtobasis(nfz, RgX_RgXQ_eval(x, C->p, C->R));
    1120         147 :   return idealhnf_two(nfz,I);
    1121             : }
    1122             : /* lift ideal pr in nf to ONE prime in nfz (the others are conjugate under tau
    1123             :  * and bring no further information on e_1 W). Assume pr coprime to
    1124             :  * index of both nf and nfz, and unramified in Kz/K (minor simplification) */
    1125             : static GEN
    1126         378 : prlifttoKz(GEN nfz, GEN nf, GEN pr, compo_s *C)
    1127             : {
    1128         378 :   GEN F, p = pr_get_p(pr), t = pr_get_gen(pr), T = nf_get_pol(nfz);
    1129         378 :   if (nf_get_degree(nf) != 1)
    1130             :   { /* restrict to primes above pr */
    1131         350 :     t = Q_primpart( lifttoKz(nf,t,C) );
    1132         350 :     T = FpX_gcd(FpX_red(T,p), FpX_red(t,p), p);
    1133         350 :     T = FpX_normalize(T, p);
    1134             :   }
    1135         378 :   F = FpX_factor(T, p);
    1136         378 :   return primedec_apply_kummer(nfz,gcoeff(F,1,1), pr_get_e(pr), p);
    1137             : }
    1138             : static GEN
    1139         217 : get_przlist(GEN L, GEN nfz, GEN nf, compo_s *C)
    1140             : {
    1141             :   long i, l;
    1142         217 :   GEN M = cgetg_copy(L, &l);
    1143         217 :   for (i = 1; i < l; i++) gel(M,i) = prlifttoKz(nfz, nf, gel(L,i), C);
    1144         217 :   return M;
    1145             : }
    1146             : 
    1147             : static void
    1148         231 : compositum_red(compo_s *C, GEN P, GEN Q)
    1149             : {
    1150         231 :   GEN p, q, a, z = gel(compositum2(P, Q),1);
    1151         231 :   a = gel(z,1);
    1152         231 :   p = gel(gel(z,2), 2);
    1153         231 :   q = gel(gel(z,3), 2);
    1154         231 :   C->k = itos( gel(z,4) );
    1155             :   /* reduce R. FIXME: should be polredbest(a, 1), but breaks rnfkummer bench */
    1156         231 :   z = polredabs0(a, nf_ORIG|nf_PARTIALFACT);
    1157         231 :   C->R = gel(z,1);
    1158         231 :   a = gel(gel(z,2), 2);
    1159         231 :   C->p = RgX_RgXQ_eval(p, a, C->R);
    1160         231 :   C->q = RgX_RgXQ_eval(q, a, C->R);
    1161         231 :   C->rev = QXQ_reverse(a, C->R);
    1162         231 :   if (DEBUGLEVEL>1) err_printf("polred(compositum) = %Ps\n",C->R);
    1163         231 : }
    1164             : 
    1165             : /* replace P->C^(-deg P) P(xC) for the largest integer C such that coefficients
    1166             :  * remain algebraic integers. Lift *rational* coefficients */
    1167             : static void
    1168         252 : nfX_Z_normalize(GEN nf, GEN P)
    1169             : {
    1170             :   long i, l;
    1171         252 :   GEN C, Cj, PZ = cgetg_copy(P, &l);
    1172         252 :   PZ[1] = P[1];
    1173        1386 :   for (i = 2; i < l; i++) /* minor variation on RgX_to_nfX (create PZ) */
    1174             :   {
    1175        1134 :     GEN z = nf_to_scalar_or_basis(nf, gel(P,i));
    1176        1134 :     if (typ(z) == t_INT)
    1177         735 :       gel(PZ,i) = gel(P,i) = z;
    1178             :     else
    1179         399 :       gel(PZ,i) = ZV_content(z);
    1180             :   }
    1181         252 :   (void)ZX_Z_normalize(PZ, &C);
    1182             : 
    1183         504 :   if (C == gen_1) return;
    1184         154 :   Cj = C;
    1185         700 :   for (i = l-2; i > 1; i--)
    1186             :   {
    1187         546 :     if (i != l-2) Cj = mulii(Cj, C);
    1188         546 :     gel(P,i) = gdiv(gel(P,i), Cj);
    1189             :   }
    1190             : }
    1191             : 
    1192             : /* v[i] = g^i mod ell, 1 <= i < m */
    1193             : static GEN
    1194         231 : Fl_powers_FpV(ulong g, long m, ulong ell)
    1195             : {
    1196         231 :   GEN v = cgetg(m, t_VEC);
    1197         231 :   ulong gi = g % ell;
    1198             :   long i;
    1199         231 :   for (i=1; i<m; i++) { gel(v,i) = utoi(gi); gi = (gi*g) % ell; }
    1200         231 :   return v;
    1201             : }
    1202             : 
    1203             : static GEN
    1204         308 : _rnfkummer(GEN bnr, GEN subgroup, long all, long prec)
    1205             : {
    1206             :   long ell, i, j, m, d, dK, dc, rc, ru, rv, g, mginv, degK, degKz, vnf;
    1207             :   long lSp, lSml2, lSl2, lW;
    1208             :   GEN polnf,bnf,nf,bnfz,nfz,bid,ideal,cycgen,gell,p1,p2,vselmer;
    1209             :   GEN cyc,gen;
    1210             :   GEN Q,idealz,gothf;
    1211         308 :   GEN res=NULL,u,M,K,y,vecMsup,vecW,vecWA,vecWB,vecB,vecC,vecAp,vecBp;
    1212             :   GEN matP, Sp, listprSp, Tc, Tv, P;
    1213             :   primlist L;
    1214             :   toK_s T;
    1215             :   tau_s _tau, *tau;
    1216             :   compo_s COMPO;
    1217             :   pari_timer t;
    1218         308 :   long rk=0, ncyc=0;
    1219         308 :   GEN mat = NULL;
    1220         308 :   long firstpass = all<0;
    1221             : 
    1222         308 :   if (DEBUGLEVEL) timer_start(&t);
    1223         308 :   checkbnr(bnr);
    1224         308 :   bnf = bnr_get_bnf(bnr);
    1225         308 :   nf  = bnf_get_nf(bnf);
    1226         308 :   polnf = nf_get_pol(nf); vnf = varn(polnf);
    1227         308 :   if (!vnf) pari_err_PRIORITY("rnfkummer", polnf, "=", 0);
    1228             :   /* step 7 */
    1229         308 :   p1 = bnrconductor_i(bnr, subgroup, 2);
    1230         308 :   if (DEBUGLEVEL) timer_printf(&t, "[rnfkummer] conductor");
    1231         308 :   bnr      = gel(p1,2);
    1232         308 :   subgroup = gel(p1,3);
    1233         308 :   gell = get_gell(bnr,subgroup,all);
    1234         308 :   ell = itos(gell);
    1235         308 :   if (ell == 1) return pol_x(0);
    1236         308 :   if (!uisprime(ell)) pari_err_IMPL("kummer for composite relative degree");
    1237         308 :   if (all && all != -1 && umodiu(bnr_get_no(bnr), ell))
    1238           7 :     return cgetg(1, t_VEC);
    1239         301 :   if (bnf_get_tuN(bnf) % ell == 0)
    1240          70 :     return rnfkummersimple(bnr, subgroup, gell, all);
    1241             : 
    1242         231 :   if (all == -1) all = 0;
    1243         231 :   bid = bnr_get_bid(bnr);
    1244         231 :   ideal = bid_get_ideal(bid);
    1245             :   /* step 1 of alg 5.3.5. */
    1246         231 :   if (DEBUGLEVEL>2) err_printf("Step 1\n");
    1247         231 :   compositum_red(&COMPO, polnf, polcyclo(ell,vnf));
    1248             :   /* step 2 */
    1249         231 :   if (DEBUGLEVEL>2) err_printf("Step 2\n");
    1250         231 :   if (DEBUGLEVEL) timer_printf(&t, "[rnfkummer] compositum");
    1251         231 :   degK  = degpol(polnf);
    1252         231 :   degKz = degpol(COMPO.R);
    1253         231 :   m = degKz / degK;
    1254         231 :   d = (ell-1) / m;
    1255         231 :   g = (long)Fl_powu(pgener_Fl(ell), d, ell);
    1256         231 :   if (Fl_powu((ulong)g, m, ell*ell) == 1) g += ell;
    1257             :   /* ord(g) = m in all (Z/ell^k)^* */
    1258             :   /* step 3 */
    1259         231 :   if (DEBUGLEVEL>2) err_printf("Step 3\n");
    1260             :   /* could factor disc(R) using th. 2.1.6. */
    1261         231 :   bnfz = Buchall(COMPO.R, nf_FORCE, maxss(prec,BIGDEFAULTPREC));
    1262         231 :   if (DEBUGLEVEL) timer_printf(&t, "[rnfkummer] bnfinit(Kz)");
    1263         231 :   cycgen = check_and_build_cycgen(bnfz);
    1264         231 :   nfz = bnf_get_nf(bnfz);
    1265         231 :   cyc = bnf_get_cyc(bnfz); rc = prank(cyc,ell);
    1266         231 :   gen = bnf_get_gen(bnfz);
    1267         231 :   u = get_u(cyc, rc, gell);
    1268             : 
    1269         231 :   vselmer = get_Selmer(bnfz, cycgen, rc);
    1270         231 :   if (DEBUGLEVEL) timer_printf(&t, "[rnfkummer] Selmer group");
    1271         231 :   ru = (degKz>>1)-1;
    1272         231 :   rv = rc+ru+1;
    1273         231 :   tau = get_tau(&_tau, nfz, &COMPO, g);
    1274             : 
    1275             :   /* step 4 */
    1276         231 :   if (DEBUGLEVEL>2) err_printf("Step 4\n");
    1277         231 :   vecB=cgetg(rc+1,t_VEC);
    1278         231 :   Tc=cgetg(rc+1,t_MAT);
    1279         371 :   for (j=1; j<=rc; j++)
    1280             :   {
    1281         140 :     p1 = tauofideal(gel(gen,j), tau);
    1282         140 :     p1 = isprincipalell(bnfz, p1, cycgen,u,gell,rc);
    1283         140 :     gel(Tc,j)  = gel(p1,1);
    1284         140 :     gel(vecB,j)= gel(p1,2);
    1285             :   }
    1286             : 
    1287         231 :   vecC = cgetg(rc+1,t_VEC);
    1288         231 :   if (rc)
    1289             :   {
    1290         126 :     for (j=1; j<=rc; j++) gel(vecC,j) = cgetg(1, t_MAT);
    1291         126 :     p1 = cgetg(m,t_VEC);
    1292         126 :     gel(p1,1) = matid(rc);
    1293         126 :     for (j=2; j<=m-1; j++) gel(p1,j) = gmul(gel(p1,j-1),Tc);
    1294         126 :     p2 = vecB;
    1295         294 :     for (j=1; j<=m-1; j++)
    1296             :     {
    1297         168 :       GEN z = FpM_red(gmulsg((j*d)%ell,gel(p1,m-j)), gell);
    1298         168 :       p2 = tauofvec(p2, tau);
    1299         364 :       for (i=1; i<=rc; i++)
    1300         196 :         gel(vecC,i) = famat_mul(gel(vecC,i), famat_factorback(p2,gel(z,i)));
    1301             :     }
    1302         126 :     for (i=1; i<=rc; i++) gel(vecC,i) = famat_reduce(gel(vecC,i));
    1303             :   }
    1304             :   /* step 5 */
    1305         231 :   if (DEBUGLEVEL>2) err_printf("Step 5\n");
    1306         231 :   Tv = cgetg(rv+1,t_MAT);
    1307        1057 :   for (j=1; j<=rv; j++)
    1308             :   {
    1309         826 :     p1 = tauofelt(gel(vselmer,j), tau);
    1310         826 :     if (typ(p1) == t_MAT) /* famat */
    1311         140 :       p1 = nffactorback(nfz, gel(p1,1), FpC_red(gel(p1,2),gell));
    1312         826 :     gel(Tv,j) = isvirtualunit(bnfz, p1, cycgen,cyc,gell,rc);
    1313             :   }
    1314         231 :   P = FpM_ker(RgM_Rg_add_shallow(Tv, stoi(-g)), gell);
    1315         231 :   lW = lg(P); vecW = cgetg(lW,t_VEC);
    1316         231 :   for (j=1; j<lW; j++) gel(vecW,j) = famat_factorback(vselmer, gel(P,j));
    1317             :   /* step 6 */
    1318         231 :   if (DEBUGLEVEL>2) err_printf("Step 6\n");
    1319         231 :   Q = FpM_ker(RgM_Rg_add_shallow(shallowtrans(Tc), stoi(-g)), gell);
    1320             :   /* step 8 */
    1321         231 :   if (DEBUGLEVEL>2) err_printf("Step 8\n");
    1322         231 :   p1 = RgXQ_matrix_pow(COMPO.p, degKz, degK, COMPO.R);
    1323         231 :   T.invexpoteta1 = RgM_inv(p1); /* left inverse */
    1324         231 :   T.polnf = polnf;
    1325         231 :   T.tau = tau;
    1326         231 :   T.m = m;
    1327         231 :   T.powg = Fl_powers_FpV(g, m, ell);
    1328             : 
    1329         231 :   idealz = ideallifttoKz(nfz, nf, ideal, &COMPO);
    1330         231 :   if (umodiu(gcoeff(ideal,1,1), ell)) gothf = idealz;
    1331             :   else
    1332             :   { /* ell | N(ideal) */
    1333         126 :     GEN bnrz = Buchray(bnfz, idealz, nf_INIT|nf_GEN);
    1334         126 :     GEN subgroupz = invimsubgroup(bnrz, bnr, subgroup, &T);
    1335         126 :     gothf = bnrconductor_i(bnrz,subgroupz,0);
    1336             :   }
    1337             :   /* step 9, 10, 11 */
    1338         231 :   if (DEBUGLEVEL>2) err_printf("Step 9, 10 and 11\n");
    1339         231 :   i = build_list_Hecke(&L, nfz, NULL, gothf, gell, tau);
    1340         231 :   if (i) return no_sol(all,i);
    1341             : 
    1342         231 :   lSml2 = lg(L.Sml2)-1;
    1343         231 :   Sp = shallowconcat(L.Sm, L.Sml1); lSp = lg(Sp)-1;
    1344         231 :   listprSp = shallowconcat(L.Sml2, L.Sl); lSl2 = lg(listprSp)-1;
    1345             : 
    1346             :   /* step 12 */
    1347         231 :   if (DEBUGLEVEL>2) err_printf("Step 12\n");
    1348         231 :   vecAp = cgetg(lSp+1, t_VEC);
    1349         231 :   vecBp = cgetg(lSp+1, t_VEC);
    1350         231 :   matP  = cgetg(lSp+1, t_MAT);
    1351             : 
    1352         385 :   for (j=1; j<=lSp; j++)
    1353             :   {
    1354             :     GEN e, a;
    1355         154 :     p1 = isprincipalell(bnfz, gel(Sp,j), cycgen,u,gell,rc);
    1356         154 :     e = gel(p1,1); gel(matP,j) = e;
    1357         154 :     a = gel(p1,2);
    1358         154 :     gel(vecBp,j) = famat_mul(famat_factorback(vecC, gneg(e)), a);
    1359             :   }
    1360         231 :   vecAp = lambdaofvec(vecBp, &T);
    1361             :   /* step 13 */
    1362         231 :   if (DEBUGLEVEL>2) err_printf("Step 13\n");
    1363         231 :   vecWA = shallowconcat(vecW, vecAp);
    1364         231 :   vecWB = shallowconcat(vecW, vecBp);
    1365             : 
    1366             :   /* step 14, 15, and 17 */
    1367         231 :   if (DEBUGLEVEL>2) err_printf("Step 14, 15 and 17\n");
    1368         231 :   mginv = (m * Fl_inv(g,ell)) % ell;
    1369         231 :   vecMsup = cgetg(lSml2+1,t_VEC);
    1370         231 :   M = NULL;
    1371         518 :   for (i=1; i<=lSl2; i++)
    1372             :   {
    1373         287 :     GEN pr = gel(listprSp,i);
    1374         287 :     long e = pr_get_e(pr), z = ell * (e / (ell-1));
    1375             : 
    1376         287 :     if (i <= lSml2)
    1377             :     {
    1378         133 :       z += 1 - L.ESml2[i];
    1379         133 :       gel(vecMsup,i) = logall(nfz, vecWA,lW,mginv,ell, pr,z+1);
    1380             :     }
    1381         287 :     M = vconcat(M, logall(nfz, vecWA,lW,mginv,ell, pr,z));
    1382             :   }
    1383         231 :   dc = lg(Q)-1;
    1384         231 :   if (dc)
    1385             :   {
    1386         105 :     GEN QtP = gmul(shallowtrans(Q), matP);
    1387         105 :     M = vconcat(M, shallowconcat(zero_Flm(dc,lW-1), ZM_to_Flm(QtP,ell)));
    1388             :   }
    1389         231 :   if (!M) M = zero_Flm(1, lSp + lW - 1);
    1390             : 
    1391         231 :   if (!all)
    1392             :   { /* primes landing in subgroup must be totally split */
    1393         217 :     GEN lambdaWB = shallowconcat(lambdaofvec(vecW, &T), vecAp);/*vecWB^lambda*/
    1394         217 :     GEN Lpr = get_prlist(bnr, subgroup, ell, bnfz);
    1395         217 :     GEN Lprz= get_przlist(Lpr, nfz, nf, &COMPO);
    1396         217 :     GEN M2 = subgroup_info(bnfz, Lprz, ell, lambdaWB);
    1397         217 :     M = vconcat(M, M2);
    1398             :   }
    1399             :   /* step 16 */
    1400         231 :   if (DEBUGLEVEL>2) err_printf("Step 16\n");
    1401         231 :   K = Flm_ker(M, ell);
    1402         231 :   if (all < 0)
    1403           0 :     K = fix_kernel(K, M, vecMsup, lW, ell);
    1404             :   /* step 18 & ff */
    1405         231 :   if (DEBUGLEVEL>2) err_printf("Step 18\n");
    1406         231 :   dK = lg(K)-1;
    1407         231 :   y = cgetg(dK+1,t_VECSMALL);
    1408         231 :   if (all) res = cgetg(1, t_VEC);
    1409         231 :   if (DEBUGLEVEL) timer_printf(&t, "[rnfkummer] candidate list");
    1410         231 :   if (all < 0) { ncyc = dK; rk = 0; mat = zero_Flm(lg(M)-1, ncyc); }
    1411             : 
    1412             :   do {
    1413         231 :     dK = lg(K)-1;
    1414         483 :     while (dK)
    1415             :     {
    1416         238 :       for (i=1; i<dK; i++) y[i] = 0;
    1417         238 :       y[i] = 1; /* y = [0,...,0,1,0,...,0], 1 at dK'th position */
    1418             :       do
    1419             :       { /* cf. algo 5.3.18 */
    1420         252 :         GEN H, be, P, X = Flm_Flc_mul(K, y, ell);
    1421         252 :         if (ok_congruence(X, ell, lW, vecMsup))
    1422             :         {
    1423         252 :           pari_sp av = avma;
    1424         252 :           if (all < 0)
    1425             :           {
    1426           0 :             gel(mat, rk+1) = X;
    1427           0 :             if (Flm_rank(mat,ell) <= rk) continue;
    1428           0 :             rk++;
    1429             :           }
    1430         252 :           be = compute_beta(X, vecWB, gell, bnfz);
    1431         252 :           P = compute_polrel(nfz, &T, be, g, ell);
    1432         252 :           nfX_Z_normalize(nf, P);
    1433         252 :           if (DEBUGLEVEL>1) err_printf("polrel(beta) = %Ps\n", P);
    1434         252 :           if (!all) {
    1435         217 :             H = rnfnormgroup(bnr, P);
    1436         217 :             if (ZM_equal(subgroup, H)) return P; /* DONE */
    1437           0 :             avma = av; continue;
    1438             :           } else {
    1439          35 :             GEN P0 = Q_primpart(lift(P));
    1440          35 :             GEN g = nfgcd(P0, RgX_deriv(P0), polnf, nf_get_index(nf));
    1441          35 :             if (degpol(g)) continue;
    1442          35 :             H = rnfnormgroup(bnr, P);
    1443          35 :             if (!ZM_equal(subgroup,H) && !bnrisconductor(bnr,H)) continue;
    1444             :           }
    1445          35 :           P = gerepilecopy(av, P);
    1446          35 :           res = shallowconcat(res, P);
    1447          35 :           if (all < 0 && rk == ncyc) return res;
    1448          35 :           if (firstpass) break;
    1449             :         }
    1450          35 :       } while (increment(y, dK, ell));
    1451          21 :       y[dK--] = 0;
    1452             :     }
    1453          14 :   } while (firstpass--);
    1454          14 :   if (all) return res;
    1455           0 :   return gen_0; /* FAIL */
    1456             : }
    1457             : 
    1458             : GEN
    1459         308 : rnfkummer(GEN bnr, GEN subgroup, long all, long prec)
    1460             : {
    1461         308 :   pari_sp av = avma;
    1462         308 :   return gerepilecopy(av, _rnfkummer(bnr, subgroup, all, prec));
    1463             : }

Generated by: LCOV version 1.11