Igor Schein on Fri, 12 Nov 1999 10:38:59 -0500


[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: matdet() bug


On Fri, Nov 12, 1999 at 01:41:44PM +0100, Bill Allombert wrote:
> A patch for matdet bug.
> 
> However, I do not see why nbco==1 was a special case.
> 
> (CVS version updated)
> Index: src/basemath/alglin1.c
> ===================================================================
> RCS file: /home/megrez/cvsroot/pari/src/basemath/alglin1.c,v
> retrieving revision 1.2
> diff -u -r1.2 alglin1.c
> --- src/basemath/alglin1.c      1999/10/31 17:59:44     1.2
> +++ src/basemath/alglin1.c      1999/11/12 12:39:44
> @@ -1971,7 +1971,7 @@
>      if (DEBUGLEVEL > 7) msgtimer("det, col %ld / %ld",i,nbco-1);
>    }
>    p = gcoeff(a,nbco,nbco);
> -  if (s < 0) p = gneg(p); else if (nbco==1) p = gcopy(p);
> +  if (s < 0) p = gneg(p); else p = gcopy(p);
>    return gerepileupto(av, p);
>  }

Well, version 2.0.14 also has nbco==1 as special case, but the bug
is not exhibited there.  Just curious.

Thanks

Igor