Bill Allombert on Sun, 24 Jan 2016 23:49:06 +0100


[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Guard stack size warnings with DEBUGMEM


On Wed, Jan 20, 2016 at 10:34:34AM +0100, Jeroen Demeyer wrote:
> On 2016-01-14 10:31, Jeroen Demeyer wrote:
> >I don't like random warnings about the stack size to appear, what do you
> >think of this patch?
> >
> >You could even make debugmem=1 the default if you want.
> 
> This is a better version of my initial patch. It makes the stack
> size warnings appear only if debugmem>0. However, it also sets
> debugmem=1 the default such that nothing will change in practice.

However this breaks backward compatibility, since users could
have set it to 0 in their .gprc, etc.

This patch is activating by default some warnings that used to be
only activated when DEBUGMEM>0.
In particular this cause 'make bench' to fail for the debug build
(Olinux-x86_64.dbg).

In any case I do not think it makes sense to change the interface each
time someone would like to silence a warning.
We need a global solution for this, preferably with a better
granularity.

Cheers,
Bill.