Eitan Adler on Sun, 08 Dec 2013 16:44:31 +0100

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: small patch for src/languages/es.c

On Sun, Dec 8, 2013 at 9:56 AM, Karim Belabas
<Karim.Belabas@math.u-bordeaux1.fr> wrote:
> * Bill Allombert [2013-12-08 14:12]:
>> On Sun, Dec 08, 2013 at 12:44:08AM -0500, Eitan Adler wrote:
>>> commit e16f45f601c8e9afc03157c5659ce8213d05b83a
>>> Author: Eitan Adler <lists@eitanadler.com>
>>> Date:   Sun Dec 8 00:33:06 2013 -0500
>>>     termios.h should be found in the root of the include path, not in
>>>     $INCLUDE_PATH/sys
>> What is the rationale for the change? You should state what you want to
>> achieve.
>> Your patch is not correct since you did not change config/has_TIOCGWINSZ.c to
>> match.
> (My commit changes both.)

Thanks, I was unaware of the config/ change.

>> As far as I can see POSIX indeed requires #include <termios.h>. However
>> POSIX does not seem to mention TIOCGWINSZ, and I do not know any system which
>> have TIOCGWINSZ but where #include <sys/termios.h> does not work.

[10010 eitan@gravity (99%) ~ ]%cat foo.c
#include <sys/termios.h>
[10011 eitan@gravity (99%) ~ !1!]%cc -c foo.c
In file included from foo.c:1:
/usr/include/sys/termios.h:3:2: warning: "this file includes <sys/termios.h>
      which is deprecated, use <termios.h> instead" [-W#warnings]
#warning "this file includes <sys/termios.h> which is deprecated, use <t...
1 warning generated.

was my rationale.

[ snip the interesting discussion ]