Bill Allombert on Tue, 15 Sep 2009 00:40:26 +0200

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: Static analyzer run

On Mon, Sep 14, 2009 at 10:00:32AM +0200, Lorenz Minder wrote:
> Hi,
> Then it uncovered a few real bugs. I (hope I) fixed those in
> sa_bugfixes.patch.

I applied this one (revision 11911).

I need more checks for the other issues.
(For example
-  prec = polred_init(T, &F, &d);
+  polred_init(T, &F, &d);

The problem is that some other analyzer report that polred_init() return value
is ignored, so we have to write
(void)polred_init(T, &F, &d);
or decide it is not improper to call the return value 'prec', even if we
do not use it.

Thanks a lot for all this work!