Ilya Zakharevich on Fri, 25 Oct 2002 23:10:41 -0700


[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Re: [PATCH CVS] log and colors and prettyprint


On Fri, Oct 25, 2002 at 10:32:48PM +0200, Karim BELABAS wrote:
> On Wed, 16 Oct 2002, Ilya Zakharevich wrote:
> > I suspect that most of the people do not want to see meaningless
> > escapes and tex-formatting in the log file, right?
> >
> > The following patch disables escape sequences and the-line-noise-which-
> > is-the-input-for-prettyprinter when writing to the log file.
> >
> > The "proper" solution may be to have two extra flags (or bits of
> > default(log)) to enable/disable these "features"; but I hope that most
> > people do not want to go back.
> 
> I've only partially applied this patch. As Bill pointed out, escape sequences
> in logfile work nicely:
> 
> * you can display them with cat, more, or less -r.

No.  Only if your TERM is the same, your background is the same etc.
This behavior is acceptable only if governed by some switch [but this
is easy to set up with the other patches of mine - hmm, not exactly;
only if one uses readline_flag & ~0x10 to enable readline, instead of
the current if (readline)...].

> * you can filter them out with misc/gpflog [also easy to set up as a
> preprocessor for your favourite text editor].

Not possible with my favourite text editor.  ;-)

Ilya